[DRAFT] Use the one flatbuffer to store all lists #489
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| pub(crate) fn filter_list(&self) -> fb::NetworkFilterList<'_> { | ||
| unsafe { fb::root_as_network_filter_list_unchecked(self.data()) } | ||
| pub(crate) fn root(&self) -> fb::Engine<'_> { | ||
| unsafe { fb::root_as_engine_unchecked(self.data()) } |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Detected 'unsafe' usage, please audit for secure usage
Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage
Cc @thypon @kdenhartog
| flatbuffers::Vector<'a, flatbuffers::ForwardsUOffset<NetworkFilterList>>, | ||
| >>(Engine::VT_LISTS, None) | ||
| .unwrap() | ||
| } |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Detected 'unsafe' usage, please audit for secure usage
Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage
Cc @thypon @kdenhartog
| None, | ||
| ) | ||
| .unwrap() | ||
| } |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] Detected 'unsafe' usage, please audit for secure usage
Source: https://semgrep.dev/r/rust.lang.security.unsafe-usage.unsafe-usage
Cc @thypon @kdenhartog
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: a1042ef | Previous: 1c4e2ac | Ratio |
|---|---|---|---|
memory-usage/brave-list-initial |
16282069 ns/iter (± 3) |
16225933 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/max |
78824921 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1.22 |
memory-usage/brave-list-initial/alloc-count |
1514487 ns/iter (± 3) |
1514650 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2516487 ns/iter (± 3) |
2505576 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
66556 ns/iter (± 3) |
66038 ns/iter (± 3) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
No description provided.