-
Notifications
You must be signed in to change notification settings - Fork 164
Enable cosmetic filter benchmarks, add resources #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust Benchmark
Benchmark suite | Current: 7912a9c | Previous: d2e870c | Ratio |
---|---|---|---|
rule-match-browserlike/brave-list |
2237973262 ns/iter (± 18291880 ) |
2218369928 ns/iter (± 12441920 ) |
1.01 |
rule-match-first-request/brave-list |
989267 ns/iter (± 8020 ) |
993380 ns/iter (± 27500 ) |
1.00 |
blocker_new/brave-list |
149383525 ns/iter (± 1655705 ) |
150901091 ns/iter (± 1059000 ) |
0.99 |
blocker_new/brave-list-deserialize |
62665902 ns/iter (± 1075987 ) |
63992983 ns/iter (± 1761826 ) |
0.98 |
memory-usage/brave-list-initial |
18831613 ns/iter (± 3 ) |
16225933 ns/iter (± 3 ) |
1.16 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3 ) |
64817658 ns/iter (± 3 ) |
1 |
memory-usage/brave-list-initial/alloc-count |
1515544 ns/iter (± 3 ) |
1514650 ns/iter (± 3 ) |
1.00 |
memory-usage/brave-list-1000-requests |
2505592 ns/iter (± 3 ) |
2505592 ns/iter (± 3 ) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
66139 ns/iter (± 3 ) |
66070 ns/iter (± 3 ) |
1.00 |
url_cosmetic_resources/brave-list |
210439 ns/iter (± 3262 ) |
||
cosmetic-class-id-match/brave-list |
4283928 ns/iter (± 1184172 ) |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10
.
Benchmark suite | Current: 7912a9c | Previous: d2e870c | Ratio |
---|---|---|---|
memory-usage/brave-list-initial |
18831613 ns/iter (± 3 ) |
16225933 ns/iter (± 3 ) |
1.16 |
This comment was automatically generated by workflow using github-action-benchmark.
1d81d9b
to
6734e0b
Compare
* Enable cosmetic filter benchmarks, add resources * Update the component name
* Enable cosmetic filter benchmarks, add resources * Update the component name
The PR improves benchmarks to support future work on cosmetic filters:
brave-resources.json
;NOTE: this PR intentionally makes
memory-usage/brave-list-initial
worse by taking into accountresources.json