Skip to content

respect default list metadata during live tests #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025

Conversation

antonok-edm
Copy link
Collaborator

This is more robust than assuming the 0th element in the list is the only relevant one, and fixes the currently broken live test.

@antonok-edm antonok-edm requested a review from atuchin-m August 12, 2025 19:38
@antonok-edm antonok-edm self-assigned this Aug 12, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: ebbf483 Previous: 4738d3f Ratio
rule-match-browserlike/brave-list 2237764084 ns/iter (± 8772899) 2252126465 ns/iter (± 13369021) 0.99
rule-match-first-request/brave-list 983996 ns/iter (± 8651) 1000284 ns/iter (± 8364) 0.98
blocker_new/brave-list 148483964 ns/iter (± 819287) 150674514 ns/iter (± 1975624) 0.99
blocker_new/brave-list-deserialize 63639518 ns/iter (± 896426) 62360204 ns/iter (± 1865060) 1.02
memory-usage/brave-list-initial 16225933 ns/iter (± 3) 16225933 ns/iter (± 3) 1
memory-usage/brave-list-initial/max 64817658 ns/iter (± 3) 64817658 ns/iter (± 3) 1
memory-usage/brave-list-initial/alloc-count 1514650 ns/iter (± 3) 1514650 ns/iter (± 3) 1
memory-usage/brave-list-1000-requests 2505592 ns/iter (± 3) 2505592 ns/iter (± 3) 1
memory-usage/brave-list-1000-requests/alloc-count 66070 ns/iter (± 3) 66070 ns/iter (± 3) 1

This comment was automatically generated by workflow using github-action-benchmark.

@antonok-edm antonok-edm merged commit f62b181 into master Aug 12, 2025
8 of 9 checks passed
@antonok-edm antonok-edm deleted the live-tests-default-lists branch August 12, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants