Fix mismatched_lifetime_syntaxes #508
Merged
+14
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
force-pushed
the
fix-mismatched_lifetime_syntaxes
branch
from
84f7f23 to
56f260d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: a03bb8e | Previous: f15e8a3 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2260398466 ns/iter (± 8972714) |
2229390776 ns/iter (± 17671286) |
1.01 |
rule-match-first-request/brave-list |
1001220 ns/iter (± 4955) |
994066 ns/iter (± 3696) |
1.01 |
blocker_new/brave-list |
155257774 ns/iter (± 1305323) |
153266661 ns/iter (± 1659115) |
1.01 |
blocker_new/brave-list-deserialize |
67344397 ns/iter (± 1179767) |
64183570 ns/iter (± 1176166) |
1.05 |
memory-usage/brave-list-initial |
17549140 ns/iter (± 3) |
17549140 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3) |
64817658 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1515544 ns/iter (± 3) |
1515544 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests |
2505576 ns/iter (± 3) |
2505576 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
66123 ns/iter (± 3) |
66123 ns/iter (± 3) |
1 |
url_cosmetic_resources/brave-list |
210818 ns/iter (± 1780) |
209381 ns/iter (± 2760) |
1.01 |
cosmetic-class-id-match/brave-list |
4331318 ns/iter (± 1197539) |
4318678 ns/iter (± 1180356) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
atuchin-m
force-pushed
the
fix-mismatched_lifetime_syntaxes
branch
2 times, most recently
from
055c9bc to
cefed55
Compare
atuchin-m
force-pushed
the
fix-mismatched_lifetime_syntaxes
branch
from
cefed55 to
a03bb8e
Compare
atuchin-m
commented
Aug 14, 2025
| @@ -15,7 +15,14 @@ use crate::regex_manager::RegexManager; | |||
| use crate::request::Request; | |||
| use crate::utils::{Hash, ShortHash}; | |||
|
|
|||
| #[allow(dead_code, clippy::all, unused_imports, unsafe_code)] | |||
| #[allow(unknown_lints)] | |||
There was a problem hiding this comment.
This is necessary for old Rust versions to support disabling mismatched_lifetime_syntaxes
antonok-edm
approved these changes
Aug 15, 2025
atuchin-m
added a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses a new Rust warning
mismatched_lifetime_syntaxes