Support generichide rules #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriusA
approved these changes
May 22, 2020
src/blocker.rs
Outdated
| @@ -1346,14 +1389,13 @@ mod legacy_rule_parsing_tests { | |||
| // easyList = { 24478, 31144, 0, 5589 }; | |||
| // not handling (and not including) filters with the following options: | |||
| // - $popup | |||
| // - $generichide | |||
| // - $subdocument | |||
There was a problem hiding this comment.
not about this PR, but I think we actually do handle $subdocument
There was a problem hiding this comment.
looks like $document right below is handled too. I'll go ahead and remove both.
There was a problem hiding this comment.
$document only somewhat - there is a spec for handling main document url blocking, but not implemented
There was a problem hiding this comment.
ah oops, I'll add that back then 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
$generichideexception rules (as well as the corresponding uBO-style alias,$ghide). These are network rules that prevent generic cosmetic element hiding from being applied to matching URLs.This partially addresses #1.