Correct MariaDB runtime library verison check #1406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MariaDB C/C version used by mysql_get_client_info() version is different from the server version exposed as MARIADB_CLIENT_VERSION_STR. The correct C/C version will be MARIADB_PACKAGE_VERSION. Fixes brianmario#1391.
This was referenced Jul 16, 2025
|
Thank you! |
|
I just restarted all of the CI jobs, looks like a GitHub failure |
|
Is that still the case (GitHub failure)? Or is some assistance required? |
|
Link to the upstream ticket for reference https://jira.mariadb.org/browse/CONC-282 GitHub Actions were kind of a mess for their own reasons, but this does appear to be passing for the MariaDB builds. Unclear exactly if there's test coverage that exercises the MariaDB Connector/C library. An improvement for another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MariaDB C/C version used by mysql_get_client_info() version is different from the server version exposed as MARIADB_CLIENT_VERSION_STR. The correct C/C version will be MARIADB_PACKAGE_VERSION.
Fixes #1391.