Skip to content

fix:check player reference before calling it #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix:check player reference before calling it #96

merged 1 commit into from
Jul 19, 2022

Conversation

randresfbc
Copy link
Contributor

Fix: check for player's reference before calling it

  • make sure the player instance exists before calling this.player.el(), happens when using embedType='iframe'

misteroneill
misteroneill approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @randresfbc!

@misteroneill misteroneill merged commit a184999 into brightcove:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@misteroneill misteroneill misteroneill approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randresfbc @misteroneill