remove sources from generated iOS pbxproj #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
commented
May 7, 2020
There was a problem hiding this comment.
✅tested native module & view module with example on Android & iOS with React Native 0.62
✅tested native module with example on iOS with React Native 0.60 & 0.61
✅tested native module with example on Android, iOS, and tvOS with react-native-tvos 0.62
✅tested view module with example on Android, iOS, and tvOS with react-native-tvos 0.62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: Objective-C module sources are not needed in the iOS pbxproj, now that they are picked up by the podfile.
should target new 0.x release
Testing: