Adding initial support for LLM Customisation #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanveer-osahan
changed the title
miguelg719
previously approved these changes
Jul 3, 2025
| @@ -1,4 +1,4 @@ | |||
| <div id="toc" align="center" style="margin-bottom: 0;"> | |||
| from litellm.proxy.client.cli.commands.models import models<div id="toc" align="center" style="margin-bottom: 0;"> | |||
There was a problem hiding this comment.
let's revert the readme changes
| @@ -19,7 +19,7 @@ class StagehandConfig(BaseModel): | |||
| browserbase_session_create_params (Optional[BrowserbaseSessionCreateParams]): Browserbase session create params. | |||
| browserbase_session_id (Optional[str]): Session ID for resuming Browserbase sessions. | |||
| model_name (Optional[str]): Name of the model to use. | |||
| model_api_key (Optional[str]): Model API key. | |||
| model_client_options (Optional[dict[str, Any]]): Options for the model client. | |||
There was a problem hiding this comment.
rather than replace, lets add it as another option
|
|
||
| # Handle model-related settings | ||
| self.model_client_options = self.config.model_client_options or {} | ||
| self.model_api_key = self.model_client_options.get("apiKey") or os.getenv("MODEL_API_KEY") |
There was a problem hiding this comment.
model_api_key supersedes the model_client_options apiKey, if defined
miguelg719
requested changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for custom language models (LLMs) by replacing the
model_api_keyparameter with a more flexiblemodel_client_optionsparameter. It also updates the documentation, configuration, initialization logic, and tests to reflect this enhancement.Core Changes for Custom LLM Support:
Configuration Updates:
model_api_keywithmodel_client_optionsin theStagehandConfigclass, allowing users to specify multiple options such asapiKeyandbaseUrlfor custom LLMs. (stagehand/config.py, [1] [2]Initialization Logic:
stagehand/main.pyto handlemodel_client_optionsand extractapiKeyfrom it, falling back to theMODEL_API_KEYenvironment variable if necessary. (stagehand/main.py, stagehand/main.pyL71-R74)model_client_optionsdynamically. (stagehand/main.py, stagehand/main.pyL92-L96)LLM Client Enhancements:
stagehand/llm/client.pyto supportbaseURLin addition toapi_basefor custom LLM configurations. (stagehand/llm/client.py, stagehand/llm/client.pyL57-R57)Documentation Updates:
StagehandConfigwithmodel_client_optionsfor a custom LLM. (README.md, README.mdR163-R178)Test Coverage:
model_api_keywithmodel_client_options. (tests/unit/llm/test_llm_integration.py, [1];tests/unit/test_client_api.py, [2];tests/unit/test_client_initialization.py, [3]tests/unit/test_client_initialization.py, tests/unit/test_client_initialization.pyR206-R234)