-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Description
Title:
Allow Stagehand to Attach to an Existing Playwright Page for Proper Video Recording
Summary:
When integrating Stagehand with Playwright tests, video recording fails to work as expected. The root cause is that Stagehand’s current initialization (via init()
or the deprecated initFromPage()
) creates its own browser context and page rather than attaching to the Playwright test runner’s page. Since Playwright’s video recording is configured at the context level (the one that the test runner creates), any actions performed in a separate Stagehand‑created context are not recorded.
What’s Happening:
-
Playwright’s Test Runner:
- Creates a browser context and page with video recording enabled (per settings like
video: "retain-on-failure"
). - Expects to manage the lifecycle (creation/closure) of that context to trigger video finalization.
- Creates a browser context and page with video recording enabled (per settings like
-
Stagehand’s Current Behavior:
- When calling
init()
, Stagehand creates its own browser context and page, independent of the Playwright-managed one. - This new context isn’t set up with video recording, so even if it’s closed later, Playwright never records the test actions.
- When calling
-
Result:
- Tests that use Stagehand’s methods (like
observe()
,act()
, etc.) run on a page that isn’t being recorded, causing missing or blank video artifacts.
- Tests that use Stagehand’s methods (like
Proposed Solution:
Modify Stagehand to allow its initialization to accept an existing Playwright page. Specifically:
-
Extend the Initialization API:
- Add an optional parameter (e.g.,
init({ page: existingPage })
or anattachToPage
option) so that if a Playwright page is provided, Stagehand attaches to that page and its context.
- Add an optional parameter (e.g.,
-
Behavior in "Attached" Mode:
- Use the provided Playwright page instead of creating a new one.
- Set the internal
context
toprovidedPage.context()
. - Avoid closing the page or context on teardown—leaving that responsibility to the test runner.
-
Benefits:
- Ensures that all Stagehand operations occur in the same context that Playwright manages.
- Preserves Playwright’s video recording, tracing, and other artifact mechanisms.
- Provides a consistent and reliable test environment for users leveraging Stagehand’s AI features.
Impact:
-
For Users:
- Tests will now properly record videos when using Stagehand’s methods, making debugging easier.
- A cleaner integration between Stagehand and the Playwright test runner.
-
For Maintenance:
- Aligns Stagehand’s lifecycle management with Playwright’s, reducing confusion and potential side effects.
- Allows continued use of AI-driven automation without sacrificing the rich artifact collection provided by Playwright.
Next Steps:
- Implement the API change in Stagehand’s initialization code.
- Add tests to ensure that when a page is attached, video recording works as expected.
- Document the new usage pattern for contributors and users.