Skip to content

Conversation

jeremypress
Copy link
Contributor

Why

we need evals that pass. in this example the demo button would resolve to multiple selectors on the page which you can't verify (you need one). We take the same naive approach we take with act that we'll take the first valid resolution of a selector. This can be improved later

What changed

  1. take the first locator when observing
  2. waitForDomSettled has to be called in user space for now. the callback we were using was not await-able. more on this later as this becomes a problem we need to squash.

Test plan

The eval passes now!

@jeremypress jeremypress merged commit 42ddf2d into main May 20, 2024
@pkiv pkiv deleted the jp-eval branch October 29, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant