Add test malformed_package_json directory to npm ignore to avoid problems with FlowJS

[alexander-schranz]

Better solution ignore whole test directory: #269

Flow JS is since the latest release failing in our cases with:

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/resolve/test/resolver/malformed_package_json/package.json:2:1

Unexpected end of input, expected the token }

See also: https://github.com/sulu/sulu/runs/4761348253?check_suite_focus=true

I think the whole test directory is not required to be in the publish packages and so it will reduce also the download size of this package.

[ljharb]

No, you’ve just posted 2 duplicate PRs to this repo - this and #269 - to “fix” something that isn’t broken. This file is intentionally published (as are all tests) and must forever be, and the solution is to flowignore the file until flow fixes its bug that crashes on third party files.

See #262.

[alexander-schranz]

@ljharb Thank you for your quick response.

No, you’ve just posted 2 duplicate PRs to this repo

Don't wanted to spam, I wanted to provide 2 different solutions for the problem.

This file is intentionally published (as are all tests)

I'm curious why test are here published? For environmental reasons we always should keep a package as small as possible, specially if it's so widely used and downloaded many times ;)

until flow fixes its bug that crashes on third party files.

Do you know the referencing issue on the flow side?

[ljharb]

To avoid spamming on open source projects, please don’t send any PRs until the maintainers have agreed there’s something worth fixing.

See #268 (comment) for an explanation.

I don’t use flow, so I’m not sure - it’s possible nobody’s filed one yet. if you do, please link it here.

[alexander-schranz]

@ljharb really sorry for the spam. Seems we live in different bubbles in my PHP world we are happy for everyone digging into things themselves try to provide a Pull Request.

Wish you a good day and start into the week!

[ljharb]

I love unsolicited pull requests for actual problems, but as you can see from that linked issue, people often send unwanted PRs for things that are not broken and are by design, like this one.