Fix round-trip serialisation by explicitly rendering id and data-id attributes - #27
Open
kiusau wants to merge 1 commit into
Open
Fix round-trip serialisation by explicitly rendering id and data-id attributes#27kiusau wants to merge 1 commit into
kiusau wants to merge 1 commit into
Conversation
…ttributes in footnote renderHTML
Member
|
cc @mary-ext |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
The
Footnotenode'saddAttributes()method did not include explicitrenderHTMLfunctions for theidanddata-idattributes. Without these,TipTap does not guarantee these attributes appear in the serialised HTML output,
causing the
parseHTMLrule to fail on round-trip since it requiresdata-idto identify footnote nodes.
This fix adds explicit
renderHTMLfunctions to both attributes, ensuring theyare always present in the serialised HTML.