Skip to content

Conversation

matthew-russo
Copy link
Contributor

This just updates the dependencies to the newest versions which includes the deprecation of the old shader macros and inclusion of new ones.

@bwasty
Copy link
Owner

bwasty commented Feb 4, 2019

Thanks a lot! I'll take a proper look at all PRs and test on several operating systems probably today or tomorrow evening.

@matthew-russo
Copy link
Contributor Author

If you want to wait to do all at once, I'm going to be submitting more over the next few days. And I'll test on a few different machines and work out anything I find so hopefully your test run is smooth.

@bwasty
Copy link
Owner

bwasty commented Feb 4, 2019

Works on macOS - but it would be great to also update the .diff files and the README (-> vulkano and winit versions).

@bwasty
Copy link
Owner

bwasty commented Feb 4, 2019

I'm getting a unused `#[macro_use]` import for vulkano_win (line 3) - that should be removed in all steps that have it.

@bwasty
Copy link
Owner

bwasty commented Feb 4, 2019

And another thing: the readme still mentions vulkano_shader_derive in https://github.com/bwasty/vulkan-tutorial-rs#shader-modules.

@matthew-russo
Copy link
Contributor Author

Ahh yes. I'll make those changes tonight! I didn't think to go over the preexisting documentation.

@bwasty
Copy link
Owner

bwasty commented Feb 9, 2019

Nice! Merging.

@bwasty bwasty merged commit 397d82c into bwasty:master Feb 9, 2019
matthew-russo pushed a commit to matthew-russo/vulkan-tutorial-rs that referenced this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants