Add name_to_index() & index_to_name()
#972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
Dec 18, 2023
|
Android support is blocked on rust-lang/libc#3487 |
arctic-alpaca
force-pushed
the
main
branch
3 times, most recently
from
bcb8739 to
ff23a3d
Compare
|
Nightly added a new dead code warning. The Dragonfly CI failure seem to stem from this change in libc. According to the docs linked by |
|
I've now fixed the DragonFly issue in #981. |
|
Thanks! I removed the dead code commit since you also already handled that. With CI being green, this PR should hopefully be done now. |
|
Thanks! |
32 tasks
|
This is released in rustix 0.38.29. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
name_to_index()andindex_to_name()methods. They are basically wrappers around ioctl calls described here. The relevant code in glibc can be found here forname_to_index()and here forindex_to_name().The tests pass locally but I'm not sure whether
loand/sys/class/net/lo/ifindexare universal enough to consider them acceptable for tests.