Sync syntax/binary of aliases with upstream spec #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Jan 8, 2021
| @@ -11,8 +11,14 @@ pub struct AliasSectionReader<'a> { | |||
|
|
|||
| #[derive(Debug)] | |||
| pub enum Alias<'a> { | |||
| ParentType(u32), | |||
| ParentModule(u32), | |||
| ParentType { | |||
There was a problem hiding this comment.
Maybe name these OuterType and OuterModule to match the spec more closely?
This commit Implements the sugar syntax proposed in WebAssembly/module-linking#26. The change here was to introduce a new `ItemRef` construct into the `wast` crate which represents a parenthesized reference to an item, either in the current module or a different module (e.g. optional `outer` and optional export names). Additionally an `IndexOrRef` type was added for parsing references which are either a bare index or an explicit reference to an item. All existing references to items were updated to use `ItemRef` where necessary. Additionally all locations which previously took an `Index` now store `ItemRef` and are parsed as `IndexOrRef`.
This continues to sync this implementation with WebAssembly/module-linking#26 by implementing the ability for outer aliases to have an arbitrary depth listed on them.
alexcrichton
force-pushed
the
text-format-sugar
branch
from
54d4026 to
85f7c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements two features from WebAssembly/module-linking#26:
(func $instance "export_name")is implemented everywhere for all items as a syntax sugar for alias references.wasmparserand validation to allow referring to any outer module.