Upgrade to witx 0.8.0 with tagged unions #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bindgen tests became out-of-date with the latest changes to the representation of unions, and the re-jiggering of various struct definitions that went along with it.
pchickey
force-pushed
the
pch/witx_tagged_unions
branch
from
b59a9d2 to
b8e83aa
Compare
|
Looks like I still need to fix the uses of these unions on all the platforms that |
|
You can probably get by with |
alexcrichton
approved these changes
Feb 20, 2020
kubkon
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements WebAssembly/WASI#220
Additionally, deletes all bindgen layout tests, since those became out-of-date with this PR. Instead, generate layout tests in
wig, usingwitx::Layoutas the source of truth.