Patch CBor round-trip QCheck test to hold for nan's too #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The forthcoming QCheck 0.26 release ocaml/opam-repository#28148 changes the distribution of the
float
generator to avoid blind spots: c-cube/qcheck#350As a consequence, the existing round-trip property-based test for CBor now fails to hold, as
nan = nan
doesn't hold, resulting in, e.g.:This PR patches the round-trip property with a recursively defined equality predicate, falling back on
Float.equal
to comparenan
s (which has the desired behaviour).