Larastan 3.x and fixes for the phpstan errors #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # phpstan-baseline.neon # src/Filament/Resources/IncidentResource.php # src/Filament/Resources/ScheduleResource.php
|
Thanks @olivernybroe 🎉 |
jbrooksuk
added a commit
that referenced
this pull request
Dec 18, 2024
* main: (49 commits) Remove unused `spatie/laravel-ray` dependency Configure run-tests on and schedule Run tests across MySQL, Postgres and SQLite (#142) Fix code styling Fix fetching of incident and schedule updateables Fix code styling Change integer types for status columns Compile Assets Update API endpoint descriptions Compile Assets Reinstate incident user relationship Update README.md incorrect sponsor URL (#141) Remove incorrect status field Fix code styling Larastan 3.x and fixes for the phpstan errors (#140) Fix Static Analysis check by removing types (#138) Fix code styling Add a `cachet:make:user` command (#139) Test fixing action Make User resource mixin of Authenticatable ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to larastan 3.x which includes phpstan 2.x and fix all the errors reported.
1 error in the seeder had to be ignored, as it seems like a Larastan bug.
Another error in api resources had to be ignored, as the typing seems wrong in JsonApi package
Lastly in the
src/Http/Resources/Metric.phpan error is ignored for field status as the field doesn't seem to exist. Couldn't find it in the migrations, but didn't want to delete the line if it was actually needed.