[fix] name mapping in request data classes #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a snake case name mapper PHP attribute to
BaseData
.closes #225
Problem Context
As discovered in #225, the API tests are returning a false positive, because of the Laravel Data configuration used for testbench:
Setting both of these values to
NULL
and running the test suite highlights the error. Of course, this is fine in our tests as we are specifying the Laravel app to uses these mappers. However applications consuming this package might not have Laravel Data configured this way.The fix
Since we have architectural tests in place to ensure that all
XyzRequestData
classes must be declaredfinal
and must extendBaseData
, we are able to fix the problem by simply adding the following attribute above the class declaration forBaseData
: