Skip to content

[WIP] Lorri #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[WIP] Lorri #17

wants to merge 3 commits into from

Conversation

roberth
Copy link
Contributor

@roberth roberth commented Sep 18, 2019

No description provided.

@roberth roberth requested a review from domenkozar September 18, 2019 15:09
@roberth roberth changed the title Lorri [WIP] Lorri Sep 25, 2019
@roberth roberth mentioned this pull request Sep 25, 2019
5 tasks
bors bot added a commit that referenced this pull request Oct 2, 2019
19: Use the module system r=roberth a=roberth

Closes #2
Closes #17 

TODO
 - [x] ~expose and test "core" module set from project.nix~
 - [x] ~niv update -b master project.nix when that's done (hercules-ci/project.nix#10
 - [x] changelog entry: (elaborate on) translate `.pre-commit-config.yaml` to hooks argument
 - [x] update README
 - [x] add how to add a hook to README

New
 - Selectively enable tools (#2)
 - Make choice of tool versions overridable
 - User-definable hooks
 - Input validation at the Nix level
 - Use gitignore by default

Fixes
 - Stop installing files all over the place when doing nix-shell ../some-project to borrow a tool
 - Lorri support

Cleanup
 - Get rid of some installation code

Co-authored-by: Robert Hensing <[email protected]>
@roberth roberth closed this in #19 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant