Skip to content

Fix backward compatibility #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix backward compatibility #232

merged 1 commit into from
Jan 23, 2023

Conversation

shikanime
Copy link
Contributor

Fix the backward compatibility issue introduced by #227 for pre 22.11 release.

@shikanime
Copy link
Contributor Author

shikanime commented Jan 23, 2023

We should also add tests for at least one late version in the matrix, is there a best practice for this? As Flake is locked for the repository, but other repositories can use follows

@domenkozar
Copy link
Member

I'm hoping to get to #196 one day that will fix issues like this.

@shikanime shikanime marked this pull request as ready for review January 23, 2023 15:19
@shikanime
Copy link
Contributor Author

Btw, I believe the revive package had the same compat issue ?

@domenkozar domenkozar merged commit 3a12b64 into cachix:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants