Skip to content

feat: add woodpecker-cli lint hook #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acid-bong
Copy link

@acid-bong acid-bong commented May 11, 2025

I only implemented the args for the workflow config path (positional), strict mode (lint-specific) and disabled network-dependent update check (global option; same page, at the top -- the headings don't have anchors). The only args, whose syntax I don't quite understand (yet), are plugin-related ones Already implemented, they are supposed to be comma-separated:

--plugins-privileged="": allow plugins to run in privileged mode, if set empty, there is no (default: [])

--plugins-trusted-clone="": plugins that are trusted to handle Git credentials in cloning steps (default: [docker.io/woodpeckerci/plugin-git:2.6.3 docker.io/woodpeckerci/plugin-git quay.io/woodpeckerci/plugin-git])

The rest of the global flags are network-dependent and require authorization to the necessary Woodpecker server, and the lint subcommand works offline, hence I didn't bother to implement those.

A tip I'd like to ask you for: is woodpecker-cli-lint a good name for the hook? On one hand, it's more accurate that just woodpecker-cli, cuz I'm only implementing one subcommand, and woodpecker-lint, cuz the hook runs specifically woodpecker-cli, and the woodpecker executable (without -cli) is getting deprecated. On the other hand, those two options (or a simple woodpecker) are shorter.

@acid-bong acid-bong marked this pull request as draft May 11, 2025 11:07
@acid-bong acid-bong force-pushed the feat/woodpecker-cli branch from d010a1e to f73b7bb Compare May 12, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant