Remove gemfile.lock #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-nosar
approved these changes
Oct 29, 2019
jmoody
suggested changes
Oct 29, 2019
There was a problem hiding this comment.
This is not enough.
We need to add Gemfile.lock to the .gitignore.
It is legacy Gemfile.lock that contains dependency on run_loop 3.x (current version is 4.x)
Another solution would have been to run bundle update and commit the new Gemfile.lock to GitHub. However, I think removing is correct choice because we are trying to automate the maintenance of these repos and I can foresee cases where we would need to manually visit the repo to update the Gemfile.lock.
ivan-nosar
approved these changes
Oct 30, 2019
|
I made a note that we need to investigate the flickering tests on Xcode 11.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemfile.lockfrom root of projectIt is legacy
Gemfile.lockthat contains dependency on run_loop 3.x (current version is 4.x) so it causes cucumber test failures.Let's remove
Gemfile.lockand just install latest version viabundle install