Simplified binary operations for DFAs #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract generic BFS code
EduardoGoulart1
commented
Apr 5, 2023
Closed
|
See #133 for past discussion |
EduardoGoulart1
force-pushed
the
simplify-binary-operations
branch
from
8dbd1b2 to
3f4534b
Compare
|
I haven't had time to do a full review, but everything here looks really good (+1 for accurate type hints everywhere) and cleaner than the previous code. None of the test cases or parts of the public interface are modified, so I'm inclined to say this should be merged soon. |
eliotwrobson
approved these changes
Apr 5, 2023
Where the other DFA-specific types already live.
|
I've resolved the remaining conversation threads by just committing those small tweaks myself. @EduardoGoulart1 did you have any other changes you wanted to make to this PR before I perform a final review / merge? |
No... Go ahead! |
This will make subclassing DFA more flexible.
caleb531
force-pushed
the
simplify-binary-operations
branch
from
2f4c4e7 to
da0c141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR. Hope it is good to go now