-
Notifications
You must be signed in to change notification settings - Fork 414
Add minimal runtime for dynamic props with IE 11 #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think it's worth it. IE11 is going away, even big enterprise companies that I work with are dropping it this year. |
@klimashkin See #446, the implementation is tiny. |
Going to close as it has been a while and I'm not sure if this is relevant anymore. |
I wonder why people don't use data attributes to implement dynamic styling?
Is there some downside to this approach that I am missing? |
@Jayphen it does not work if you need to use dynamic style from API or database. |
There are a relatively new polyfill exist: https://github.com/nuxodin/ie11CustomProperties
Maybe add a flag to linaria (like useIEStyleAttrubute) which will use both attributes will be much simpler solution here? |
Do you want to request a feature or report a bug?
Feature.
What is the current behavior?
dynamic styled props do not work with IE 11.
What is the wanted behavior?
They should. It'd be nice if Linaria had a very minimal runtime to modify the stylesheet and dynamically adjust css variables based on passed in props such that they work in IE 11.
I believe this is possible but I could be wrong.
Related: jhildenbiddle/css-vars-ponyfill#5
The lack of IE 11 support is a production blocker for Linaria for many projects.
See facebook/create-react-app#5224
See https://www.reddit.com/r/reactjs/comments/aojnyd/announcing_linaria_10_zero_runtime_cssinjs_library/eg1xsvm?utm_source=share&utm_medium=web2x
The text was updated successfully, but these errors were encountered: