Skip to content

Minimal IE Runtime #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Minimal IE Runtime #446

wants to merge 4 commits into from

Conversation

nhooyr
Copy link

@nhooyr nhooyr commented Jul 3, 2019

See #445

Summary

Adds a very minimal runtime for IE. Not the most robust but should work well for our purposes.

See #445

Test plan

Not really sure yet.

@nhooyr nhooyr changed the title Initial Minimal IE Runtime Minimal IE Runtime Jul 3, 2019
@nhooyr nhooyr marked this pull request as ready for review July 3, 2019 08:18
@nhooyr
Copy link
Author

nhooyr commented Jul 3, 2019

The way it work is that when a css variable needs to be modified, instead of just adding an inline style, the IE code will find the rule in the stylesheet that uses the css variable on the class, replace the variable with the value and add this new rule to a dynamically injected stylesheet.

@nhooyr
Copy link
Author

nhooyr commented Jul 3, 2019

Not sure if the rule cache here is necessary. For the rule on every dynamic CSS variable, is the selector just the class?

@pbitkowski
Copy link
Contributor

Thanks for your contribution! Is this possible to extract this logic to another library, to make this opt-in feature? I know it's tiny, but we don't to do it by default to keep our core small and happy.

@dreyks
Copy link

dreyks commented Jul 15, 2019

@pbitkowski how do you feel about making it a separate library indeed but scoping it under callstack? that way the core could still be kept small but the library won't get lost in the future?

@nhooyr
Copy link
Author

nhooyr commented Jul 22, 2019

Don't have the time to work on this anymore. Someone else feel free to continue.

@nhooyr nhooyr closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants