Skip to content

chore: nitro modules ci fails #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

chore: nitro modules ci fails #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29907ed
update nitro modules version
atlj May 9, 2025
3ee39be
ci: update cocoapod cache key
satya164 May 13, 2025
26b8746
ci: use xcode 16.3 for builds
satya164 May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/build-templates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,16 @@ on:
jobs:
build:
env:
XCODE_VERSION: 16.2
XCODE_VERSION: 16.3
TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
TURBO_TEAM: ${{ secrets.TURBO_TEAM }}

strategy:
fail-fast: false
matrix:
os:
- ubuntu
- macos
- ubuntu-latest
- macos-15
type:
- name: turbo-module
language: kotlin-objc
Expand All @@ -40,15 +40,16 @@ jobs:
- name: nitro-module
language: kotlin-swift
include:
- os: ubuntu
type.name: library
type.language: js
- os: ubuntu-latest
type:
name: library
language: js

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-${{ matrix.type.name }}-${{ matrix.type.language }}
cancel-in-progress: true

runs-on: ${{ matrix.os }}-latest
runs-on: ${{ matrix.os }}

steps:
- name: Checkout
Expand Down Expand Up @@ -130,14 +131,14 @@ jobs:
working-directory: ${{ env.work_dir }}
run: |
# Build Android for only some matrices to skip redundant builds
if [[ ${{ matrix.os }} == ubuntu ]]; then
if [[ ${{ matrix.os }} =~ ubuntu ]]; then
if [[ ${{ matrix.type.name }} == *-view && ${{ matrix.type.language }} == *-objc ]] || [[ ${{ matrix.type.name }} == *-module && ${{ matrix.type.language }} == *-objc ]]; then
echo "android_build=1" >> $GITHUB_ENV
fi
fi

# Build iOS for only some matrices to skip redundant builds
if [[ ${{ matrix.os }} == macos ]]; then
if [[ ${{ matrix.os }} =~ macos ]]; then
if [[ ${{ matrix.type.name }} == *-view && ${{ matrix.type.language }} == kotlin-* ]] || [[ ${{ matrix.type.name }} == *-module && ${{ matrix.type.language }} == kotlin-* ]]; then
echo "ios_build=1" >> $GITHUB_ENV
fi
Expand Down Expand Up @@ -239,8 +240,9 @@ jobs:
path: |
${{ env.work_dir }}/**/ios/Pods
${{ env.work_dir }}/**/ios/Podfile.lock
key: ${{ runner.os }}-library-cocoapods-${{ hashFiles(format('{0}/example/ios/Podfile', env.work_dir)) }}-${{ hashFiles(format('{0}/yarn.lock', env.work_dir)) }}
key: ${{ runner.os }}-library-cocoapods-${{ hashFiles(format('{0}/example/ios/Podfile', env.work_dir)) }}-${{ hashFiles(format('{0}/yarn.lock', env.work_dir)) }}-${{ hashFiles(format('{0}/**/*ViewNativeComponent.ts', env.work_dir), format('{0}/**/Native*.ts', env.work_dir), format('{0}/**/*.nitro.ts', env.work_dir)) }}
restore-keys: |
${{ runner.os }}-library-cocoapods-${{ hashFiles(format('{0}/example/ios/Podfile', env.work_dir)) }}-${{ hashFiles(format('{0}/yarn.lock', env.work_dir)) }}-
${{ runner.os }}-library-cocoapods-${{ hashFiles(format('{0}/example/ios/Podfile', env.work_dir)) }}-
${{ runner.os }}-library-cocoapods-

Expand Down
2 changes: 1 addition & 1 deletion packages/create-react-native-library/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export const FALLBACK_BOB_VERSION = '0.40.8';
export const FALLBACK_NITRO_MODULES_VERSION = '0.22.1';
export const FALLBACK_NITRO_MODULES_VERSION = '0.25.2';
export const SUPPORTED_REACT_NATIVE_VERSION = '0.79.2';
Loading