refactor: module android impl from Java to Kotlin #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retyui
approved these changes
Nov 14, 2023
- convert files from Java to Kotlin - replace deprecated onCatalystInstanceDestroy with invalidate - replace deprecated AsyncTask classes with Kotlin Coroutines
- add spotless & ktfmt - format existing android code - add lint & format scripts in package.json - add lint step in code-quality job
mateusz1913
force-pushed
the
refactor/android-kotlin
branch
from
25d7cd9 to
401a056
Compare
This was referenced Jan 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts Android implementation from Java to Kotlin
Test plan
Run the app on Android (old and new arch), it should work as expected.