chore: Upgrade react-native to latest version #81
Conversation
| ] | ||
|
|
||
| apply from: "../../../node_modules/react-native/react.gradle" | ||
| apply from: "../../node_modules/react-native/react.gradle" |
There was a problem hiding this comment.
This path is incorrect. The repo is set up in a way that in the root is a library with all required dependencies. In Example directory, there is an example app that is supposed to use the library, react-native, and all other dependencies from the root and not from its own node_modules.
This needs to be reverted.
There was a problem hiding this comment.
@Trancever @dratwas said he's fine with creation of 2 separated package.json and simplify this path's.
There was a problem hiding this comment.
Also it's worth to mention that some of our packages have separate example package.json like paper, viewpager, fbads
example/android/app/build.gradle
Outdated
| minifyEnabled enableProguardInReleaseBuilds | ||
| proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro" | ||
| // Detox-specific additions to pro-guard | ||
| proguardFile "${rootProject.projectDir}/../node_modules/detox/android/detox/proguard-rules-app.pro" |
There was a problem hiding this comment.
Please make sure it points to the correct node_modules
| @@ -161,3 +222,5 @@ task copyDownloadableDepsToLibs(type: Copy) { | |||
| from configurations.compile | |||
| into 'libs' | |||
| } | |||
|
|
|||
| apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) | |||
There was a problem hiding this comment.
| apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) | |
| apply from: file("../../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project) |
| rootProject.name = 'ImageEditorExample' | ||
|
|
||
| rootProject.name = 'ReactNativeImageEditorExample' | ||
| apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings) |
There was a problem hiding this comment.
Please make sure this path points to node_modules in the root.
example/package.json
Outdated
| "test:android:build:debug": "detox build -c android.emu.debug", | ||
| "test:android:build:release": "detox build -c android.emu.release", | ||
| "test:android:bundle:release": "mkdir -p .tmp && react-native bundle --max-workers 4 --platform android --dev false --entry-file index.js --bundle-output .tmp/android-bundle.js", | ||
| "test:ios:test:debug": "detox test -c ios.sim.debug", |
There was a problem hiding this comment.
We don't need this file. Example app should use same dependencies as library. Check my first comment for more information
MateWW
force-pushed
the
rn-upgrade
branch
2 times, most recently
from
d25952c to
7ec2d12
Compare
|
Thanks for PR |
No description provided.