chore(next): upgrade RN version in both examples #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krozniata
changed the title
|
|
||
| # Version of flipper SDK to use with React Native | ||
| FLIPPER_VERSION=0.174.0 | ||
| FLIPPER_VERSION=0.182.0 |
There was a problem hiding this comment.
Is this needed? As we are not using flipper and it's getting deprecated
There was a problem hiding this comment.
I just followed RN upgrade helper 😄 I guess it will be soon removed in 0.73
okwasniewski
approved these changes
Oct 13, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades RN version to 72.5 in both Paper and Fabric example.
It also fixes some smaller issues with building and android version getting stuck after
setPagecall in Fabric versionTest Plan
Both Paper and Fabric examples should work correctly on both platforms
Compatibility
Checklist