chore(breaking): compile project to Node 10 using @babel/preset-env #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
changed the title
thymikee
changed the title
thymikee
force-pushed
the
chore/babel-preset-env
branch
from
7142e76 to
f6a6714
Compare
thymikee
force-pushed
the
chore/babel-preset-env
branch
from
f6a6714 to
6315acb
Compare
thymikee
added a commit
that referenced
this pull request
May 28, 2020
…309) * chore: compile project to Node 8.3 using @babel/preset-env * update snapshots * compile to Node 10 * adjust snapshots back * add migration docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No need to compile the library with Metro, which intends to be run on JSC/Hermes. RNTL is consumed by Node.js. Using Node 10 and deferring this to v2. We can also make it into v1 with Node 8.3, but I don't care too much
Test plan
Unsure