Skip to content

Conversation

szymonrybczak
Copy link
Contributor

Summary

Upgraded TesterApp to latest react-native version.

Test plan

App should properly build and launch on Android and iOS.

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: ffe05bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@szymonrybczak
Copy link
Contributor Author

I tested locally and everything is building correctly, though Android app is not connecting to the bundler (for me also on main), probably I have broken setup. @jbroma mind checking this?

@szymonrybczak szymonrybczak force-pushed the chore/upgrade-react-native-version branch from 26ec469 to 5b92921 Compare December 12, 2023 13:38
@hosseinmd
Copy link
Contributor

The react-native 73 no longer utilizes @react-native-community/cli. Please ensure to replace it with @react-native-community/cli-plugin for compatibility with the latest updates.

@hosseinmd
Copy link
Contributor

Repack used that in commands

@szymonrybczak
Copy link
Contributor Author

The react-native 73 no longer utilizes @react-native-community/cli. Please ensure to replace it with @react-native-community/cli-plugin for compatibility with the latest updates.

What do you mean by no longer utilizes? We migrated one package from CLI to Core, but that's it. And we already added support for this in #477

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found outdated graddle-wrapper.jar, updated it, rest is LGTM 🚀
Thanks for handling this @szymonrybczak ❤️

@jbroma jbroma merged commit c60d88a into callstack:main Dec 14, 2023
@hosseinmd
Copy link
Contributor

TesterApp can't work without this PR #477, please merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants