-
Notifications
You must be signed in to change notification settings - Fork 149
chore(TesterApp): upgrade to [email protected] #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TesterApp): upgrade to [email protected] #476
Conversation
🦋 Changeset detectedLatest commit: ffe05bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I tested locally and everything is building correctly, though Android app is not connecting to the bundler (for me also on |
packages/TesterApp/android/app/src/main/java/com/testerapp/MainApplication.kt
Outdated
Show resolved
Hide resolved
26ec469
to
5b92921
Compare
The react-native 73 no longer utilizes @react-native-community/cli. Please ensure to replace it with @react-native-community/cli-plugin for compatibility with the latest updates. |
Repack used that in commands |
What do you mean by no longer utilizes? We migrated one package from CLI to Core, but that's it. And we already added support for this in #477 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found outdated graddle-wrapper.jar
, updated it, rest is LGTM 🚀
Thanks for handling this @szymonrybczak ❤️
TesterApp can't work without this PR #477, please merge it. |
Summary
Upgraded TesterApp to latest
react-native
version.Test plan
App should properly build and launch on Android and iOS.