[DPE -3096] Fix profile limit memory config option #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…file-limit-memory-config-option Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
taurus-forever
approved these changes
Dec 7, 2023
paulomach
approved these changes
Dec 8, 2023
marceloneppel
deleted the
dpe-3096-fix-profile-limit-memory-config-option
branch
1 task
BON4
pushed a commit
to BON4/postgresql-operator
that referenced
this pull request
Apr 23, 2024
* Update data-platform-workflows to v7 * Fix profile limit memory config option Signed-off-by: Marcelo Henrique Neppel <[email protected]> * Update related unit test Signed-off-by: Marcelo Henrique Neppel <[email protected]> * Add CRAFT_SHARED_CACHE env variable to charmcraft pack wrapper Signed-off-by: Marcelo Henrique Neppel <[email protected]> --------- Signed-off-by: Marcelo Henrique Neppel <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
profile-limit-memoryconfig option should have underscores instead of hyphens in it's name to follow the same pattern we have for the other config options.Solution
Deprecate the current config option and create a new one named
profile_limit_memory. Keep both to release a new revision to stable and then we can remove theprofile-limit-memoryconfig option in a new release to14/stablelater.One related unit test was updated.