Skip to content

[DPE-4967] Block charm if dependent objects on disabled plugins #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

lucasgameiroborges
Copy link

@lucasgameiroborges lucasgameiroborges commented Jul 31, 2024

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.96%. Comparing base (57eb505) to head (e969934).

Files Patch % Lines
src/charm.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   70.89%   70.96%   +0.06%     
==========================================
  Files          11       11              
  Lines        3024     3034      +10     
  Branches      535      538       +3     
==========================================
+ Hits         2144     2153       +9     
- Misses        764      765       +1     
  Partials      116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucasgameiroborges lucasgameiroborges changed the title add block config feature [DPE-4967] Block charm if dependent objects on disabled plugins Aug 1, 2024
@lucasgameiroborges lucasgameiroborges marked this pull request as ready for review August 1, 2024 01:29
@lucasgameiroborges lucasgameiroborges merged commit a870470 into main Aug 1, 2024
82 checks passed
@lucasgameiroborges lucasgameiroborges deleted the lucas/port-plugin-feature branch August 1, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants