Skip to content

[DPE-5712] Add warning logs to Patroni reinitialisation #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Oct 25, 2024

Adds warning and status change before re-initialising to make it more visible in logs

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.68%. Comparing base (283463b) to head (059da97).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/charm.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   71.68%   71.68%   -0.01%     
==========================================
  Files          13       13              
  Lines        3115     3118       +3     
  Branches      465      465              
==========================================
+ Hits         2233     2235       +2     
- Misses        771      772       +1     
  Partials      111      111              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dragomirp dragomirp marked this pull request as ready for review October 25, 2024 21:21
@dragomirp dragomirp requested review from a team, taurus-forever, marceloneppel and lucasgameiroborges and removed request for a team October 25, 2024 21:22
@dragomirp dragomirp merged commit 4286b57 into main Oct 27, 2024
97 checks passed
@dragomirp dragomirp deleted the add-warnings-on-reinitialise branch October 27, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants