Jg/frontend #2
Open
Jg/frontend #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monlu
reviewed
Jan 23, 2017
| @@ -61,3 +63,11 @@ | |||
| * **Fastclick**: removes 300ms delay on touch devices [source](https://github.com/ftlabs/fastclick) | |||
| * **Modernizr**: feature testing [source](https://modernizr.com/) | |||
| * **HammerJS**: adds touch gestures [source](http://hammerjs.github.io/) | |||
| * **VelocityJS**: accelerated JavaScript animations with or without jQuery [source](http://velocityjs.org/) | |||
| * **Waypoints**: useful for events triggered by scroll points [source](http://imakewebthings.com/waypoints/) | |||
| * **Underscore**: great set of utility functions (including debounce and throttle) [source](http://underscorejs.org/) | |||
There was a problem hiding this comment.
i would include lodash or swap it with underscore. it is the larger library overall, but it is modular and lets us import only the functions we need, which results in less overhead once compiled in webpack/browserify. Also I think it is the superior library to underscore and is better optimized.
There was a problem hiding this comment.
good by me. swapped it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.