Skip to content

More tables for cds build #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2025
Merged

More tables for cds build #2011

merged 6 commits into from
Aug 9, 2025

Conversation

swaldmann
Copy link
Contributor

@swaldmann swaldmann commented Aug 6, 2025

Just stumbled over our documentation for cds build and found some parts difficult to read because of some large walls of prose for configuration options, e.g. here:
https://cap.cloud.sap/docs/guides/deployment/custom-builds#build-task-properties

Let's make these MD tables, which I think is much more pleasant to read.

@swaldmann swaldmann requested review from joergmann and daogrady August 6, 2025 11:33
@swaldmann swaldmann marked this pull request as ready for review August 6, 2025 11:33
@swaldmann swaldmann requested a review from smahati as a code owner August 6, 2025 11:33
Copy link
Contributor

@daogrady daogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes! I like the conciseness. Except for the one typo I found, consider my remarks suggestions only. Therefore giving a +1 from my side already.

@swaldmann swaldmann added this pull request to the merge queue Aug 9, 2025
Merged via the queue into main with commit 6a0c2c0 Aug 9, 2025
4 checks passed
@swaldmann swaldmann deleted the tables-build branch August 9, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants