Address clippy warnings in autogenerated code #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes most clippy warnings in capnpc autogenerated code, including:
This does not semantically change the code that is generated, though the needless lifetimes fix might not be compatible with older versions of rustc (I seem to vaguely recall lifetime elison getting smarter at some point, so the explicit lifetimes may have been necessary to compile on older versions of rustc.)
For my schema, it reduces the warnings from several hundred to several dozen. The fix for the remaining warnings would require backwards-incompatible changes, so I will open a separate PR for that.