More clippy linter improvements #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng/rust#54406 This reverts commit 427eaa7.
|
Thanks! |
ErikMcClure
pushed a commit
to Fundament-Software/capstone-rs
that referenced
this pull request
Mar 25, 2024
More clippy linter improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes
32 changes:Address backwards-incompatible clippy warnings in autogenerated code #113 deprecated methods that produced clippy warnings, but they still produce warnings. This adds ignores for those lints, restricted to the deprecated methods only.Could not apply this, due to an issue with stable/beta: Unable to Refer to Clippy Lints on Beta rust-lang/rust#54406sincefield in thedeprecatedannotation should be a semver string. This fixes that.These are all in separate commits, so I can cherry-pick and open a new PR if you'd like only a subset of these fixes.