perf: Support priority deny override model without recursion

[sagilio]

close #188

[sagilio]

@apiscevs Plz review

[apiscevs]

Hi @sagilio ,

thanks for reviewing a refactoring my code.
Approach without a recursion looks good, however there is a one problem.

Code breaks if it did not find a highest level policy, in the result policy result is always false.
Expected result, is that if matching policy were not found on higher tiers, it should dive deeper.

Please use this test to reproduce an issue.

public void TestPriorityExplicitDenyOverrideWithFakeHighTierPolicyModel()
{
    var e = new Enforcer(_testModelFixture.GetNewPriorityExplicitDenyOverrideModel());
    e.BuildRoleLinks();
    TestEnforce(e, "alice", "data2", "write", true);
    // adding higher priority policy for alice, however policy's sub, obj and action are fake and never be matched
    //expected enforcement result should be true, as there is a policy with a lower rank 10, that produces allow result
    e.AddPolicy("5", "fake-subject", "fake-object", "very-fake-action", "allow");
    TestEnforce(e, "alice", "data2", "write", true);
}

I've ran this test using initial solution with recursion, it worked successfully.

[apiscevs]

looks like it can be easily fixed if check Effect result

if (hasPriority && isPriorityDenyOverrideEfffet && nowEffect != Effect.Effect.Indeterminate)
{
    if (int.TryParse(policyValues[priorityIndex], out int nowPriority))
    {
        if (priority.HasValue && nowPriority != priority.Value)
        {
            break;
        }
        priority = nowPriority;
    }
}

[sagilio]

@apiscevs You are right, I have added a new test case, please review again.

[apiscevs]

LGTM!
This is way elegant compared to recursion :)

[github-actions]

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀