Skip to content

CLI: make color output legible on dark backgrounds #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 14, 2017

Conversation

kcgthb
Copy link
Contributor

@kcgthb kcgthb commented Feb 11, 2017

ClusterShell's default colored output uses dark colors, which are difficult to read on dark background terminals. Using the light version of each color improves legibility on dark bacrounds, without affecting display on light backgrounds.

ClusterShell's default colored output uses dark colors, which are difficult to
read on dark background terminals. Using the light version of each color
improves legibility on dark bacrounds, without affecting display on light
backgrounds.
@degremont degremont added this to the 1.8 milestone Sep 7, 2017
Copy link
Collaborator

@degremont degremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the 2 typos in commit message?

ClusterShell's default colored output uses dark colors, which are difficult to
read on dark background terminals. Using the light version of each color
improves legibility on dark backgrounds, without affecting display on light
backgrounds.
@kcgthb
Copy link
Contributor Author

kcgthb commented Sep 7, 2017

Aw, I worked hard on those typos!

@degremont degremont changed the title CLI: make color output legible on dark bagrounds CLI: make color output legible on dark backgrounds Sep 14, 2017
@thiell
Copy link
Collaborator

thiell commented Sep 14, 2017

closing/opening to trigger tests as this was proposed before travis CI support

@thiell thiell closed this Sep 14, 2017
@thiell thiell reopened this Sep 14, 2017
@thiell thiell merged commit 0a4a0d6 into cea-hpc:master Sep 14, 2017
@kcgthb kcgthb deleted the colors branch May 21, 2019 14:55
@kcgthb kcgthb mentioned this pull request Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants