CLIConfigTest: Use integer division for soft limit computation #487
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI.Config.ClushConfig (setrlimit) test fails with python3.10 with
an error:
resource.setrlimit(resource.RLIMIT_NOFILE, (hard2/2, hard))
TypeError: 'float' object cannot be interpreted as an integer
The integer division solves the problem.
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Sep 11, 2022
Multiple aspects of the ebuild were changed from previous versions: - it is converted to new PEP517 mode - it supports py3.9, py3.10 and py3.11 - homepage link is fixed - it uses .gh.tar.gz suffix for source archive as suggested in Gentoo Python Guide - the doc use is removed because it is not used anymore since commit 3ca0636 ("app-admin/clustershell: version bump.") - dev-libs/openssl dependency is removed, it is not used in sources code - working tests - most of tests work with an exception of those requiring remote ssh connections, which are removed in prepare step. It was necessary to apply few fixes [1-3] taken from upstream in order to make them work. The tests are executed with unittest rather than nose which makes py3.11 support possible. - it installs man pages again, this is basically resurrected from commit 3ca0636 ("app-admin/clustershell: version bump.") - unlike legacy mode, PEP517 installs etc/* files to /usr/etc, hence it was necessary to correct installation path with move (I didn't find any better solution, this one is used across repository) [1] cea-hpc/clustershell@314767d [2] cea-hpc/clustershell#487 [3] cea-hpc/clustershell#488 Closes: https://bugs.gentoo.org/866071 Bug: https://bugs.gentoo.org/845426 Signed-off-by: Petr Vaněk <[email protected]>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Oct 4, 2022
Multiple aspects of the ebuild were changed from previous versions: - it is converted to new PEP517 mode - it supports py3.9, py3.10 and py3.11 - homepage link is fixed - it uses .gh.tar.gz suffix for source archive as suggested in Gentoo Python Guide - the doc use is removed because it is not used anymore since commit 3ca0636 ("app-admin/clustershell: version bump.") - dev-libs/openssl dependency is removed, it is not used in sources code - working tests - most of tests work with an exception of those requiring remote ssh connections, which are removed in prepare step. It was necessary to apply few fixes [1-3] taken from upstream in order to make them work. The tests are executed with unittest rather than nose which makes py3.11 support possible. - it installs man pages again, this is basically resurrected from commit 3ca0636 ("app-admin/clustershell: version bump.") - unlike legacy mode, PEP517 installs etc/* files to /usr/etc, hence it was necessary to correct installation path with move (I didn't find any better solution, this one is used across repository) [1] cea-hpc/clustershell@314767d [2] cea-hpc/clustershell#487 [3] cea-hpc/clustershell#488 Closes: https://bugs.gentoo.org/866071 Bug: https://bugs.gentoo.org/845426 Signed-off-by: Petr Vaněk <[email protected]>
arkamar
added a commit
to arkamar/gentoo
that referenced
this pull request
Oct 4, 2022
Multiple aspects of the ebuild were changed from previous versions: - it is converted to new PEP517 mode - it supports py3.9, py3.10 and py3.11 - homepage link is fixed - it uses .gh.tar.gz suffix for source archive as suggested in Gentoo Python Guide - the doc use is removed because it is not used anymore since commit 3ca0636 ("app-admin/clustershell: version bump.") - dev-libs/openssl dependency is removed, it is not used in sources code - working tests - most of tests work with an exception of those requiring remote ssh connections, which are removed in prepare step. It was necessary to apply few fixes [1-3] taken from upstream in order to make them work. The tests are executed with unittest rather than nose which makes py3.11 support possible. - it installs man pages again, this is basically resurrected from commit 3ca0636 ("app-admin/clustershell: version bump.") - unlike legacy mode, PEP517 installs etc/* files to /usr/etc, hence it was necessary to correct installation path with move (I didn't find any better solution, this one is used across repository) [1] cea-hpc/clustershell@314767d [2] cea-hpc/clustershell#487 [3] cea-hpc/clustershell#488 Closes: https://bugs.gentoo.org/866071 Bug: https://bugs.gentoo.org/845426 Signed-off-by: Petr Vaněk <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Oct 4, 2022
Multiple aspects of the ebuild were changed from previous versions: - it is converted to new PEP517 mode - it supports py3.9, py3.10 and py3.11 - homepage link is fixed - it uses .gh.tar.gz suffix for source archive as suggested in Gentoo Python Guide - the doc use is removed because it is not used anymore since commit 3ca0636 ("app-admin/clustershell: version bump.") - dev-libs/openssl dependency is removed, it is not used in sources code - working tests - most of tests work with an exception of those requiring remote ssh connections, which are removed in prepare step. It was necessary to apply few fixes [1-3] taken from upstream in order to make them work. The tests are executed with unittest rather than nose which makes py3.11 support possible. - it installs man pages again, this is basically resurrected from commit 3ca0636 ("app-admin/clustershell: version bump.") - unlike legacy mode, PEP517 installs etc/* files to /usr/etc, hence it was necessary to correct installation path with move (I didn't find any better solution, this one is used across repository) [1] cea-hpc/clustershell@314767d [2] cea-hpc/clustershell#487 [3] cea-hpc/clustershell#488 Closes: https://bugs.gentoo.org/866071 Bug: https://bugs.gentoo.org/845426 Signed-off-by: Petr Vaněk <[email protected]> Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CLI.Config.ClushConfig (setrlimit)test fails withpython3.10with an error:The integer division solves the problem.