tests: fix StreamWorker test leading to bad Engine state #502
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unconfigured StreamWorker does not have streams to register in the engine, so when registered, it stays until it is explicitly aborted. To make that worse, it is using a 'fanout slot' and if the Engine's fanout is too low, it can lead to the engine run loop exiting prematurely. This is not a case handled very well by the Engine. See cea-hpc#497 for more details about the problem. In the meantime, we fix the test to exit with a clean engine state. Fixes cea-hpc#488.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unconfigured StreamWorker does not have streams to register in the engine, so when registered, it stays until it is explicitly aborted. To make that worse, it is using a 'fanout slot' and if the Engine's fanout is too low, it can lead to the engine run loop exiting prematurely. This is not a case handled very well by the Engine. See #497 for more details about the problem.
In the meantime, we fix the test to exit with a clean engine state.
Fixes #488.