Topology: check that node groups/wildcards are non-empty (#527) #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degremont
reviewed
Sep 19, 2023
lib/ClusterShell/Topology.py
Outdated
| @@ -456,7 +456,17 @@ def _build_graph(self): | |||
| """ | |||
| self.graph = TopologyGraph() | |||
| for src, dst in self._topology: | |||
| self.graph.add_route(NodeSet(src), NodeSet(dst)) | |||
| # GH#527: router and destination node sets may use NodeSet groups | |||
| # but they have to resolve to something when we build the graph! | |||
There was a problem hiding this comment.
I'm wondering if this is really a big deal. Couldn't we just ignore those routes? If one of src or dst is empty, just don't add_route() ?
There was a problem hiding this comment.
Great point. It might be more flexible to just ignore such route, I will change that, thanks!
Router and destination node sets defined in topology.conf may use NodeSet groups and wildcards but any route definition with an empty node set when we build the tree will be ignored. Add checks for this in the code and add a note to the documentation. Fixes cea-hpc#527.
thiell
force-pushed
the
b192_topology_deadlock
branch
from
15292b8 to
4b6f944
Compare
degremont
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Router and destination node sets defined in topology.conf may use NodeSet groups and wildcards but those have to resolve to non-empty node sets when we build the tree.
Add checks for this in the code and add a note to the documentation.
Fixes #527.