Tree: use set instead of NodeSet for gwtargets tracking #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a NodeSet to track a large and frequent-changing set of remote targets can lead to performance issue as reported in cea-hpc#560, especially when RangeSetND is involved. Use a standard set instead for gwtargets tracking in the TreeWorker and adapt clush to work with sets in that case. Fixes cea-hpc#560
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a NodeSet to track a large and frequent-changing set of remote
targets can lead to performance issue as reported in #560, especially
when RangeSetND is involved.
Use a standard set instead for gwtargets tracking in the TreeWorker
and adapt clush to work with sets in that case.
Fixes #560