TestResults and Controller refactoring to reduce functions complexity #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
force-pushed
the
pr/refactor-pylint
branch
from
671e1f9 to
5d37f87
Compare
qa-cea
approved these changes
Aug 21, 2025
Refactor action_build() function in Controller module by moving part of its code in new function build_pkgs(). The purpose is to reduce complexity of action_build() and avoid reaching Pylint branching limit.
This notably allows removing results argument from many functions in Controller. One motivation of this change is to satisfy pylint which emits warnings when there are more than 5 arguments on a function. A testcase is also introduced to cover all method of TestResults class.
Thanks to refactorings brought by some parent commits, the minimum expected Pylint score can be increased.
rezib
force-pushed
the
pr/refactor-pylint
branch
from
5d37f87 to
fe134a1
Compare
qa-cea
approved these changes
Aug 25, 2025
valeriyoann
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code refactoring for the purpose of simplifying some Controller functions (reduce number of branches and arguments) to stay below Pylint thresholds. The pull request allow brings a new test case for TestResults that wasn't covered by isolated tests.