Restructure vm and gerrit configuration parameters #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezib
force-pushed
the
pr/conf-struct
branch
2 times, most recently
from
1adf462 to
1602dbc
Compare
qa-cea
requested changes
Aug 21, 2025
qa-cea
approved these changes
Aug 25, 2025
valeriyoann
reviewed
Sep 8, 2025
tests/VM.py
Outdated
| 'image': '/my_image', | ||
| } | ||
| ) | ||
| print(self.config.get('vm')) |
There was a problem hiding this comment.
minor: seems unnecessary
There was a problem hiding this comment.
My bad, fixed in 3aae0dd.
Instead of checking for required in params in sub dictionnaries at load time, check them recursively after everything is loaded. This change notably fixes bug in case required parameter in a sub dictionnary is not defined in a configuration file but defined in another file and in merged options eventually.
This is now possible to mark configuration parameters as deprecated, by specifying the name of their replacement. Arbitrary levels of dict keys can be specified in the name using dot separator (ex: hash1.hash2.key3). A FutureWarning is emitted when deprecated parameter is loaded, to alert user of the change and inform of the new parameter name. When both the deprecated and replacement parameters are defined, the deprecated parameter is ignored. Unit tests are introduced to cover all cases of this feature.
Replace all vm_* parameters by the same parameters in vm dict (eg. vm_image is becoming vm > image). All vm_* parameters are marked as deprecated, ie. they are still supported but Rift emits warning visible by end users to report the new parameter name.
Replace all gerrit_* parameters by the same parameters in gerrit dict (eg. gerrit_realm is becoming gerrit > realm). All gerrit_* parameters are marked as deprecated, ie. they are still supported but Rift emits warning visible by end users to report the new parameter name. Also add unit tests to cover Gerrit module.
rezib
force-pushed
the
pr/conf-struct
branch
from
d6e2e40 to
eb7c85a
Compare
valeriyoann
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull requests deprecates all
vm_*andgerrit_*configuration parameters and introduces newvmandgerrithashes to hold all related parameters.2 parents commits are also included to: