-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
Tests are failing after these changes. |
case 'geometry': | ||
case 'text': | ||
case 'json': | ||
return ($this->isMysql() && !$this->isMariaDb()) === false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition looks hard to read, should be positive check instead of negative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Condition:
is mysql | is mariadb | type in array | final | global negation | |
---|---|---|---|---|---|
mysql json | T | !F=T | T | T | F |
mysql nonjson | T | !F=T | F | F | T |
mariadb json | F | !T=F | T | F | T |
mariadb nonjson | F | !T=F | F | F | T |
Default are not allowed for BLOB, TEXT, GEOMETRY, and JSON in MySQL prior to MySQL 8.0.13
Curious to know why it is allowed for MariaDB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mariadb allows default value for JSON column at least, have been using that a few times. e.g. data JSON NOT NULL DEFAULT '{}'
Completing this PR in #112 |
x-db-type will no longer be reformatted from now on.
x-db-type is now the final entry in db.
nullalble property is handled correctly.
usecase
fixes #100
fixes #99