Fix test_database AttributeError on ignore_result with Celery 5.x - #510
Merged
Conversation
The protocol 1 test requests are built via hybrid_to_proto2() which does
not include 'ignore_result' in the message headers. Celery 5.x's
Request.__init__ reads 'ignore_result' from the headers and, when absent,
falls back to self._task.ignore_result. Since these tests pass the task
name rather than a task object, it causes an error:
AttributeError: 'str' object has no attribute 'ignore_result'
Set the 'ignore_result' header to False in _create_request() so the
fallback is never use. This is a no-op for protocol 2 (which already sets
the header) and keeps request.task as the 'my_task' string, preserving
the existing task_name assertions.
Closes: celery#508
Signed-off-by: Christopher Obbard <obbardc@debian.org>
auvipy
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protocol 1 test requests are built via hybrid_to_proto2() which does not include 'ignore_result' in the message headers. Celery 5.x's Request.init reads 'ignore_result' from the headers and, when absent, falls back to self._task.ignore_result. Since these tests pass the task name rather than a task object, it causes an error:
Set the 'ignore_result' header to False in _create_request() so the fallback is never use. This is a no-op for protocol 2 (which already sets the header) and keeps request.task as the 'my_task' string, preserving the existing task_name assertions.
Closes: #508